Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default timeout to fix KVS error when fetching ExtendedTimoutConfig #11904

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Add default timeout to fix KVS error when fetching ExtendedTimoutConfig #11904

merged 2 commits into from
Dec 2, 2021

Conversation

michalbudzon-q
Copy link
Contributor

@michalbudzon-q michalbudzon-q commented Nov 17, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

  • Add default timeout value
  • Replace Mdns with Dnssd

Change overview

Add call to SetExtendedDiscoveryTimeoutSecs() to set default value before use.

Testing

How was this tested?

  • Sanity test check based on the value returned by the function GetExtendedDiscoveryTimeoutSecs()

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11904: Size comparison from cbd3e95 to 28bec34

Full report (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cbd3e95 28bec34 change % change
efr32 lighting-app BRD4161A (read only) 745448 745448 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745440 745440 0 0.0
BRD4161A+rpc (read only) 732964 732964 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732956 732956 0 0.0
lock-app BRD4161A (read only) 722536 722536 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722528 722528 0 0.0
window-app BRD4161A (read only) 723496 723496 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723488 723488 0 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825128 0 0.0
(read/write) 1219762 1219762 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163912 163912 0 0.0
.flash.text 825128 825128 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896127 896127 0 0.0
(read/write) 419084 419084 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191884 191884 0 0.0
.flash.text 890743 890743 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703856 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619156 619156 0 0.0
lock-app k32w061+debug (read/write) 595300 595300 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520120 520120 0 0.0
shell k32w061+debug (read/write) 660532 660532 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574320 574320 0 0.0
linux all-clusters-app debug (read only) 1702849 1702849 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135349 0 0.0
.text 1434050 1434050 0 0.0
bridge-app debug+rpc (read only) 1298021 1298021 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110764 0 0.0
.text 1090357 1090357 0 0.0
chip-tool debug (read only) 4957053 4957053 0 0.0
(read/write) 166504 166504 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267186 0 0.0
.text 4380437 4380437 0 0.0
lighting-app debug+rpc (read only) 1567113 1567113 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128401 0 0.0
.text 1304210 1304210 0 0.0
ota-provider-app debug (read only) 1253449 1253449 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113063 0 0.0
.text 1043298 1043298 0 0.0
ota-requestor-app debug (read only) 1337025 1337025 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1113490 1113490 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846009 1846009 0 0.0
(read/write) 318136 318136 0 0.0
.bss 249960 249960 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 156653 0 0.0
.text 1544802 1544802 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284296 2284296 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246896 1246896 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232824 1232824 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2246128 2246128 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208728 1208728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 860463 0 0.0
bss 110384 110384 0 0.0
rodata 95136 95136 0 0.0
text 579316 579316 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822831 822831 0 0.0
bss 106740 106740 0 0.0
rodata 86320 86320 0 0.0
text 553488 553488 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785502 785502 0 0.0
bss 111760 111760 0 0.0
rodata 90392 90392 0 0.0
text 508788 508788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835859 835859 0 0.0
bss 109408 109408 0 0.0
rodata 91604 91604 0 0.0
text 559416 559416 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761182 0 0.0
bss 110820 110820 0 0.0
rodata 86912 86912 0 0.0
text 488976 488976 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842003 0 0.0
bss 109548 109548 0 0.0
rodata 93316 93316 0 0.0
text 563596 563596 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835595 0 0.0
bss 109444 109444 0 0.0
rodata 91564 91564 0 0.0
text 559036 559036 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292832 2292832 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251096 1251096 0 0.0
lock-app default (read/write) 2210320 2210320 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168584 1168584 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763250 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529344 529344 0 0.0

@michalbudzon-q michalbudzon-q marked this pull request as ready for review November 23, 2021 13:58
@woody-apple
Copy link
Contributor

Fast tracking given this has been stuck in review for a while without comment.

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #11904: Size comparison from ea87cc6 to 2feda42

Full report (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ea87cc6 2feda42 change % change
efr32 lighting-app BRD4161A (read only) 762728 762728 0 0.0
(read/write) 120260 120260 0 0.0
.bss 118436 118436 0 0.0
.data 1820 1820 0 0.0
.text 762720 762720 0 0.0
BRD4161A+rpc (read only) 791224 791224 0 0.0
(read/write) 138556 138556 0 0.0
.bss 136636 136636 0 0.0
.data 1920 1920 0 0.0
.text 791216 791216 0 0.0
lock-app BRD4161A (read only) 736688 736688 0 0.0
(read/write) 117964 117964 0 0.0
.bss 116188 116188 0 0.0
.data 1776 1776 0 0.0
.text 736680 736680 0 0.0
window-app BRD4161A (read only) 739736 739736 0 0.0
(read/write) 118396 118396 0 0.0
.bss 116612 116612 0 0.0
.data 1784 1784 0 0.0
.text 739728 739728 0 0.0
esp32 all-clusters-app c3devkit (read only) 836512 836512 0 0.0
(read/write) 1224890 1224890 0 0.0
.dram0.bss 59568 59568 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 166080 166080 0 0.0
.flash.text 836512 836512 0 0.0
.iram0.text 61390 61390 0 0.0
m5stack (read only) 908483 908483 0 0.0
(read/write) 424116 424116 0 0.0
.dram0.bss 64960 64960 0 0.0
.dram0.data 33960 33960 0 0.0
.flash.rodata 193916 193916 0 0.0
.flash.text 903099 903099 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724204 724204 0 0.0
.bss 78716 78716 0 0.0
.data 1844 1844 0 0.0
.text 637844 637844 0 0.0
lock-app k32w061+debug (read/write) 613276 613276 0 0.0
.bss 69164 69164 0 0.0
.data 1808 1808 0 0.0
.text 536504 536504 0 0.0
shell k32w061+debug (read/write) 679016 679016 0 0.0
.bss 80700 80700 0 0.0
.data 1780 1780 0 0.0
.text 590736 590736 0 0.0
linux all-clusters-app debug (read only) 1777433 1777433 0 0.0
(read/write) 131864 131864 0 0.0
.bss 60592 60592 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139093 139093 0 0.0
.text 1499970 1499970 0 0.0
bridge-app debug+rpc (read only) 1351629 1351629 0 0.0
(read/write) 78304 78304 0 0.0
.bss 42192 42192 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1137941 1137941 0 0.0
chip-tool debug (read only) 6127109 6127109 0 0.0
(read/write) 199576 199576 0 0.0
.bss 40544 40544 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152432 152432 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 294504 294504 0 0.0
.text 5442309 5442309 0 0.0
lighting-app debug+rpc (read only) 1631561 1631561 0 0.0
(read/write) 111424 111424 0 0.0
.bss 47888 47888 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132017 132017 0 0.0
.text 1361826 1361826 0 0.0
ota-provider-app debug (read only) 1312625 1312625 0 0.0
(read/write) 76760 76760 0 0.0
.bss 44768 44768 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1097378 1097378 0 0.0
ota-requestor-app debug (read only) 1409097 1409097 0 0.0
(read/write) 80592 80592 0 0.0
.bss 47200 47200 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1179554 1179554 0 0.0
shell debug (read only) 820977 820977 0 0.0
(read/write) 67192 67192 0 0.0
.bss 23880 23880 0 0.0
.data 224 224 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79154 79154 0 0.0
.text 635138 635138 0 0.0
tv-app debug (read only) 1924721 1924721 0 0.0
(read/write) 320896 320896 0 0.0
.bss 252248 252248 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161160 161160 0 0.0
.text 1615362 1615362 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295768 2295768 0 0.0
.bss 182308 182308 0 0.0
.data 5128 5128 0 0.0
.heap 849008 849008 0 0.0
.text 1258368 1258368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281048 2281048 0 0.0
.bss 172916 172916 0 0.0
.data 5488 5488 0 0.0
.heap 858040 858040 0 0.0
.text 1243648 1243648 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254192 2254192 0 0.0
.bss 171732 171732 0 0.0
.data 5472 5472 0 0.0
.heap 859240 859240 0 0.0
.text 1216792 1216792 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051168 2051168 0 0.0
.bss 156880 156880 0 0.0
.data 4872 4872 0 0.0
.heap 874696 874696 0 0.0
.text 1013768 1013768 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876495 876495 0 0.0
bss 113084 113084 0 0.0
rodata 97296 97296 0 0.0
text 590576 590576 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838943 838943 0 0.0
bss 109436 109436 0 0.0
rodata 88560 88560 0 0.0
text 564744 564744 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801514 801514 0 0.0
bss 114460 114460 0 0.0
rodata 92556 92556 0 0.0
text 520032 520032 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847419 847419 0 0.0
bss 110124 110124 0 0.0
rodata 93084 93084 0 0.0
text 568848 568848 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772674 772674 0 0.0
bss 111532 111532 0 0.0
rodata 88372 88372 0 0.0
text 498392 498392 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853375 853375 0 0.0
bss 110260 110260 0 0.0
rodata 94792 94792 0 0.0
text 572892 572892 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846495 846495 0 0.0
bss 110136 110136 0 0.0
rodata 92952 92952 0 0.0
text 567972 567972 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778947 778947 0 0.0
bss 109564 109564 0 0.0
rodata 73192 73192 0 0.0
text 521692 521692 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693994 693994 0 0.0
bss 110548 110548 0 0.0
rodata 67836 67836 0 0.0
text 442300 442300 0 0.0
p6 all-clusters-app default (read/write) 2317288 2317288 0 0.0
.bss 115216 115216 0 0.0
.data 2424 2424 0 0.0
.heap 915704 915704 0 0.0
.text 1275552 1275552 0 0.0
lock-app default (read/write) 2229096 2229096 0 0.0
.bss 101512 101512 0 0.0
.data 2288 2288 0 0.0
.heap 929544 929544 0 0.0
.text 1187360 1187360 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778294 778294 0 0.0
bss 79660 79660 0 0.0
noinit 37160 37160 0 0.0
text 541202 541202 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #11904: Size comparison from a9ffa78 to fa994e3

Full report (4 builds for k32w, telink)
platform target config section a9ffa78 fa994e3 change % change
k32w lighting-app k32w061+se05x+release (read/write) 724356 724356 0 0.0
.bss 78756 78756 0 0.0
.data 1844 1844 0 0.0
.text 637956 637956 0 0.0
lock-app k32w061+debug (read/write) 613348 613348 0 0.0
.bss 69204 69204 0 0.0
.data 1808 1808 0 0.0
.text 536536 536536 0 0.0
shell k32w061+debug (read/write) 679128 679128 0 0.0
.bss 80780 80780 0 0.0
.data 1780 1780 0 0.0
.text 590768 590768 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778454 0 0.0
bss 79700 79700 0 0.0
noinit 37160 37160 0 0.0
text 541270 541270 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #11904: Size comparison from a9ffa78 to f17b2fe

Full report (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a9ffa78 f17b2fe change % change
efr32 lighting-app BRD4161A (read only) 763016 763016 0 0.0
(read/write) 120300 120300 0 0.0
.bss 118476 118476 0 0.0
.data 1820 1820 0 0.0
.text 763008 763008 0 0.0
BRD4161A+rpc (read only) 791512 791512 0 0.0
(read/write) 138596 138596 0 0.0
.bss 136676 136676 0 0.0
.data 1920 1920 0 0.0
.text 791504 791504 0 0.0
lock-app BRD4161A (read only) 736896 736896 0 0.0
(read/write) 118004 118004 0 0.0
.bss 116228 116228 0 0.0
.data 1776 1776 0 0.0
.text 736888 736888 0 0.0
window-app BRD4161A (read only) 739984 739984 0 0.0
(read/write) 118436 118436 0 0.0
.bss 116652 116652 0 0.0
.data 1784 1784 0 0.0
.text 739976 739976 0 0.0
esp32 all-clusters-app c3devkit (read only) 836580 836580 0 0.0
(read/write) 1225258 1225258 0 0.0
.dram0.bss 59608 59608 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 166400 166400 0 0.0
.flash.text 836580 836580 0 0.0
.iram0.text 61390 61390 0 0.0
m5stack (read only) 908587 908587 0 0.0
(read/write) 424484 424484 0 0.0
.dram0.bss 65000 65000 0 0.0
.dram0.data 33960 33960 0 0.0
.flash.rodata 194244 194244 0 0.0
.flash.text 903203 903203 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724356 724356 0 0.0
.bss 78756 78756 0 0.0
.data 1844 1844 0 0.0
.text 637956 637956 0 0.0
lock-app k32w061+debug (read/write) 613348 613348 0 0.0
.bss 69204 69204 0 0.0
.data 1808 1808 0 0.0
.text 536536 536536 0 0.0
shell k32w061+debug (read/write) 679128 679128 0 0.0
.bss 80780 80780 0 0.0
.data 1780 1780 0 0.0
.text 590768 590768 0 0.0
linux all-clusters-app debug (read only) 1779889 1779889 0 0.0
(read/write) 131960 131960 0 0.0
.bss 60688 60688 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139957 139957 0 0.0
.text 1500914 1500914 0 0.0
bridge-app debug+rpc (read only) 1353061 1353061 0 0.0
(read/write) 78400 78400 0 0.0
.bss 42288 42288 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113820 113820 0 0.0
.text 1139125 1139125 0 0.0
chip-tool debug (read only) 6129597 6129597 0 0.0
(read/write) 199800 199800 0 0.0
.bss 40640 40640 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152560 152560 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 294664 294664 0 0.0
.text 5444421 5444421 0 0.0
lighting-app debug+rpc (read only) 1633129 1633129 0 0.0
(read/write) 111520 111520 0 0.0
.bss 47984 47984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132305 132305 0 0.0
.text 1363010 1363010 0 0.0
ota-provider-app debug (read only) 1313409 1313409 0 0.0
(read/write) 76856 76856 0 0.0
.bss 44864 44864 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114960 114960 0 0.0
.text 1098098 1098098 0 0.0
ota-requestor-app debug (read only) 1409897 1409897 0 0.0
(read/write) 80688 80688 0 0.0
.bss 47296 47296 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126464 126464 0 0.0
.text 1180290 1180290 0 0.0
shell debug (read only) 821761 821761 0 0.0
(read/write) 67288 67288 0 0.0
.bss 23976 23976 0 0.0
.data 224 224 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79218 79218 0 0.0
.text 635858 635858 0 0.0
tv-app debug (read only) 1927729 1927729 0 0.0
(read/write) 321152 321152 0 0.0
.bss 252376 252376 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61608 61608 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161448 161448 0 0.0
.text 1617842 1617842 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296160 2296160 0 0.0
.bss 182348 182348 0 0.0
.data 5128 5128 0 0.0
.heap 848968 848968 0 0.0
.text 1258760 1258760 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281096 2281096 0 0.0
.bss 172956 172956 0 0.0
.data 5488 5488 0 0.0
.heap 858000 858000 0 0.0
.text 1243696 1243696 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254192 2254192 0 0.0
.bss 171772 171772 0 0.0
.data 5472 5472 0 0.0
.heap 859200 859200 0 0.0
.text 1216792 1216792 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051232 2051232 0 0.0
.bss 156920 156920 0 0.0
.data 4872 4872 0 0.0
.heap 874656 874656 0 0.0
.text 1013832 1013832 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876639 0 0.0
bss 113124 113124 0 0.0
rodata 97344 97344 0 0.0
text 590620 590620 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839087 0 0.0
bss 109476 109476 0 0.0
rodata 88608 88608 0 0.0
text 564788 564788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801674 0 0.0
bss 114500 114500 0 0.0
rodata 92604 92604 0 0.0
text 520076 520076 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847467 0 0.0
bss 110164 110164 0 0.0
rodata 93084 93084 0 0.0
text 568872 568872 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772738 0 0.0
bss 111572 111572 0 0.0
rodata 88372 88372 0 0.0
text 498420 498420 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853479 0 0.0
bss 110300 110300 0 0.0
rodata 94816 94816 0 0.0
text 572940 572940 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846559 0 0.0
bss 110176 110176 0 0.0
rodata 92952 92952 0 0.0
text 568000 568000 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779043 0 0.0
bss 109604 109604 0 0.0
rodata 73192 73192 0 0.0
text 521724 521724 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694058 0 0.0
bss 110588 110588 0 0.0
rodata 67836 67836 0 0.0
text 442332 442332 0 0.0
p6 all-clusters-app default (read/write) 2317928 2317928 0 0.0
.bss 115256 115256 0 0.0
.data 2424 2424 0 0.0
.heap 915664 915664 0 0.0
.text 1276192 1276192 0 0.0
lock-app default (read/write) 2229400 2229400 0 0.0
.bss 101552 101552 0 0.0
.data 2288 2288 0 0.0
.heap 929504 929504 0 0.0
.text 1187664 1187664 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778454 0 0.0
bss 79700 79700 0 0.0
noinit 37160 37160 0 0.0
text 541270 541270 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #11904: Size comparison from 6b244ab to d9085e6

Increases above 0.2%:

platform target config section 6b244ab d9085e6 change % change
qpg lighting-app qpg6100+debug .data 940 944 4 0.4
lock-app qpg6100+debug .data 892 896 4 0.4
Increases (2 builds for qpg)
platform target config section 6b244ab d9085e6 change % change
qpg lighting-app qpg6100+debug (read only) 496860 496924 64 0.0
(read/write) 114140 114144 4 0.0
.data 940 944 4 0.4
.text 491540 491604 64 0.0
lock-app qpg6100+debug (read only) 469448 469520 72 0.0
(read/write) 114140 114144 4 0.0
.data 892 896 4 0.4
.text 464128 464200 72 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6b244ab d9085e6 change % change
efr32 lighting-app BRD4161A (read only) 763096 763096 0 0.0
(read/write) 119956 119956 0 0.0
.bss 118140 118140 0 0.0
.data 1812 1812 0 0.0
.text 763088 763088 0 0.0
BRD4161A+rpc (read only) 791608 791608 0 0.0
(read/write) 138252 138252 0 0.0
.bss 136340 136340 0 0.0
.data 1912 1912 0 0.0
.text 791600 791600 0 0.0
lock-app BRD4161A (read only) 736976 736976 0 0.0
(read/write) 117660 117660 0 0.0
.bss 115892 115892 0 0.0
.data 1768 1768 0 0.0
.text 736968 736968 0 0.0
window-app BRD4161A (read only) 740080 740080 0 0.0
(read/write) 118092 118092 0 0.0
.bss 116316 116316 0 0.0
.data 1776 1776 0 0.0
.text 740072 740072 0 0.0
esp32 all-clusters-app c3devkit (read only) 837376 837376 0 0.0
(read/write) 1224330 1224330 0 0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166528 166528 0 0.0
.flash.text 837376 837376 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908883 908883 0 0.0
(read/write) 423572 423572 0 0.0
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194364 194364 0 0.0
.flash.text 903499 903499 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724508 724508 0 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638096 638096 0 0.0
lock-app k32w061+debug (read/write) 613492 613492 0 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536676 536676 0 0.0
shell k32w061+debug (read/write) 679288 679288 0 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590916 590916 0 0.0
linux all-clusters-app debug (read only) 1780313 1780313 0 0.0
(read/write) 125160 125160 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65696 65696 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139957 139957 0 0.0
.text 1500738 1500738 0 0.0
bridge-app debug+rpc (read only) 1352373 1352373 0 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113980 113980 0 0.0
.text 1138181 1138181 0 0.0
chip-tool debug (read only) 6266389 6266389 0 0.0
(read/write) 197648 197648 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157608 157608 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 295752 295752 0 0.0
.text 5568293 5568293 0 0.0
lighting-app debug+rpc (read only) 1632441 1632441 0 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 57072 57072 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132433 132433 0 0.0
.text 1362098 1362098 0 0.0
ota-provider-app debug (read only) 1312817 1312817 0 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115184 115184 0 0.0
.text 1097186 1097186 0 0.0
ota-requestor-app debug (read only) 1412801 1412801 0 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 127008 127008 0 0.0
.text 1181906 1181906 0 0.0
shell debug (read only) 805881 805881 0 0.0
(read/write) 59848 59848 0 0.0
.bss 16808 16808 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38320 38320 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79954 79954 0 0.0
.text 620610 620610 0 0.0
tv-app debug (read only) 1927025 1927025 0 0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161576 161576 0 0.0
.text 1616914 1616914 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296552 2296552 0 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259152 1259152 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281312 2281312 0 0.0
.bss 172636 172636 0 0.0
.data 5480 5480 0 0.0
.heap 858328 858328 0 0.0
.text 1243912 1243912 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254344 2254344 0 0.0
.bss 171452 171452 0 0.0
.data 5464 5464 0 0.0
.heap 859528 859528 0 0.0
.text 1216944 1216944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046096 2046096 0 0.0
.bss 156592 156592 0 0.0
.data 4864 4864 0 0.0
.heap 874992 874992 0 0.0
.text 1008696 1008696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876791 876791 0 0.0
bss 113136 113136 0 0.0
rodata 97368 97368 0 0.0
text 590740 590740 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 839239 839239 0 0.0
bss 109488 109488 0 0.0
rodata 88632 88632 0 0.0
text 564908 564908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801810 801810 0 0.0
bss 114512 114512 0 0.0
rodata 92628 92628 0 0.0
text 520196 520196 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847603 847603 0 0.0
bss 110176 110176 0 0.0
rodata 93108 93108 0 0.0
text 568988 568988 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772874 772874 0 0.0
bss 111584 111584 0 0.0
rodata 88396 88396 0 0.0
text 498536 498536 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853647 853647 0 0.0
bss 110312 110312 0 0.0
rodata 94840 94840 0 0.0
text 573052 573052 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846711 846711 0 0.0
bss 110188 110188 0 0.0
rodata 92976 92976 0 0.0
text 568112 568112 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779163 779163 0 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521832 521832 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694210 694210 0 0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442444 442444 0 0.0
p6 all-clusters-app default (read/write) 2318288 2318288 0 0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276552 1276552 0 0.0
lock-app default (read/write) 2229528 2229528 0 0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187792 1187792 0 0.0
qpg lighting-app qpg6100+debug (read only) 496860 496924 64 0.0
(read/write) 114140 114144 4 0.0
.bss 79656 79656 0 0.0
.data 940 944 4 0.4
.text 491540 491604 64 0.0
lock-app qpg6100+debug (read only) 469448 469520 72 0.0
(read/write) 114140 114144 4 0.0
.bss 78568 78568 0 0.0
.data 892 896 4 0.4
.text 464128 464200 72 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778614 778614 0 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541394 541394 0 0.0

@woody-apple woody-apple merged commit 8a30959 into project-chip:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalbudzon-q @CLAassistant @woody-apple